Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error 'Unexpected: ("$", "$") while parsing field definition' #2895

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix error 'Unexpected: ("$", "$") while parsing field definition' #2895

merged 1 commit into from
Nov 9, 2020

Conversation

shokada
Copy link
Contributor

@shokada shokada commented Nov 7, 2020 •
edited
Loading

What this PR does / why we need it:
I got the following error when running tk show

-> % tk show environments/loki
evaluating jsonnet: RUNTIME ERROR: /Users/shokada/src/loki-test/vendor/loki/gateway.libsonnet:97:5-6 Unexpected: ("$", "$") while parsing field definition
        main.jsonnet:1:17-48    thunk <gateway> from <$>
        main.jsonnet:5:19-26    $
        During evaluation

refs: #2852

@codecov-io
Copy link

Codecov Report

Merging #2895 (3d264dc) into master (fd451d9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2895      +/-   ##
==========================================
- Coverage   61.63%   61.62%   -0.02%     
==========================================
  Files         181      181              
  Lines       14712    14712              
==========================================
- Hits         9068     9066       -2     
- Misses       4812     4820       +8     
+ Partials      832      826       -6
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.19% <0.00%> (+2.11%) ⬆️
pkg/storage/stores/shipper/uploads/table.go 69.58% <0.00%> (+2.76%) ⬆️

cyriltovena
cyriltovena approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 9900e69 into grafana:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shokada @codecov-io @cyriltovena